Relative: Fix calculate directly not scaling inner pars when applying to rdatas #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1534 +/- ##
===========================================
- Coverage 84.36% 84.34% -0.03%
===========================================
Files 163 163
Lines 14034 14036 +2
===========================================
- Hits 11840 11838 -2
- Misses 2194 2198 +4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the end of the
calculate_directlymethod of theRelativeAmiciCalculatorthe inner parameters that are optimized need to be applied to the rdatas (compared to the re-simulation ofcall_amici_twicewith non-dummy inner parameter values).However, the inner parameters were not scaled accordingly in this step. E.g. if the scale of a scaling inner parameter (value = 10^-2) was set to LOG10 (log10 value -2), it would stay in LOG10 scale and be applied like that (multiplying its rdata by -2) instead of being scaled to LIN scale and then being applied to the rdatas.