Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_deepcopy_objective, test_preeq_guesses #1521

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Nov 26, 2024

Failures were related to changes in amici's default steady-state settings.

@dweindl dweindl changed the title Fix test_preeq_guesses Fix test_deepcopy_objective, test_preeq_guesses Nov 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.80%. Comparing base (fae7755) to head (28bc512).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1521       +/-   ##
============================================
+ Coverage    54.39%   82.80%   +28.41%     
============================================
  Files          163      163               
  Lines        13962    13962               
============================================
+ Hits          7594    11561     +3967     
+ Misses        6368     2401     -3967     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dweindl dweindl marked this pull request as ready for review November 26, 2024 12:55
@dweindl dweindl enabled auto-merge November 26, 2024 13:00
@dweindl dweindl self-assigned this Nov 26, 2024
@dweindl dweindl disabled auto-merge November 26, 2024 15:25
@dweindl dweindl merged commit 6c049f5 into ICB-DCM:develop Nov 26, 2024
17 of 18 checks passed
@dweindl dweindl deleted the fix_1520 branch November 26, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants