Visualize: fix flatten of observable mapping with one observable #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1515 +/- ##
===========================================
+ Coverage 82.76% 84.32% +1.55%
===========================================
Files 163 163
Lines 14016 14013 -3
===========================================
+ Hits 11601 11816 +215
+ Misses 2415 2197 -218 ☔ View full report in Codecov by Sentry. |
|
@Doresic Looks good to me. |
vwiela
approved these changes
Nov 22, 2024
PaulJonasJost
approved these changes
Nov 25, 2024
|
I think there are two more such cases in |
dweindl
reviewed
Nov 27, 2024
dweindl
approved these changes
Dec 2, 2024
test/visualize/test_visualize.py
Outdated
| # Set seed for reproducibility. | ||
| np.random.seed(0) | ||
| optimizer = pypesto.optimize.ScipyOptimizer( | ||
| method="L-BFGS-B", options={"maxiter": 10} |
There was a problem hiding this comment.
For just testing that visualization does not produce an error, a single iteration would suffice, right?
stephanmg
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observable mapping visualization failed in the case of only one observable. Fixed to account for the case of one observable.