Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ESSOptimizer min of empty sequence #1510

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Nov 18, 2024

Fixes ValueError: min() arg is an empty sequence) that may cause deadlocks.

Fixes `ValueError: min() arg is an empty sequence)` that may cause deadlocks.
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.08%. Comparing base (e3b3c8a) to head (806e8b1).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1510      +/-   ##
===========================================
- Coverage    82.85%   81.08%   -1.78%     
===========================================
  Files          163      163              
  Lines        13949    13949              
===========================================
- Hits         11558    11310     -248     
- Misses        2391     2639     +248     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@dweindl dweindl self-assigned this Nov 18, 2024
@dweindl dweindl requested a review from vwiela November 19, 2024 08:12
@dweindl dweindl marked this pull request as ready for review November 19, 2024 08:12
Copy link
Contributor

@vwiela vwiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix for now, thanks.

@dweindl dweindl merged commit cf56080 into ICB-DCM:develop Nov 19, 2024
17 of 18 checks passed
@dweindl dweindl deleted the fix_ess_empty_min branch November 19, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants