Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push latest pyPESTO (develop) build as image with tag latest to docker.io #1083

Merged
merged 13 commits into from
Nov 28, 2024

Conversation

stephanmg
Copy link
Contributor

No description provided.

@stephanmg stephanmg requested a review from a team as a code owner June 21, 2023 07:11
@stephanmg stephanmg added the enhancement New feature or request label Jun 21, 2023
@stephanmg stephanmg marked this pull request as draft June 21, 2023 07:15
@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.81%. Comparing base (bd98004) to head (3beed50).
Report is 2 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1083      +/-   ##
===========================================
- Coverage    82.82%   82.81%   -0.01%     
===========================================
  Files          163      163              
  Lines        13962    13962              
===========================================
- Hits         11564    11563       -1     
- Misses        2398     2399       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yannikschaelte
Copy link
Member

Sounds good to me, would you use the docker image?

@stephanmg
Copy link
Contributor Author

@yannikschaelte yes, I would use it, mostly in situations when run on a VM.

@stephanmg
Copy link
Contributor Author

Rather should be deployed to Github registry not docker.

@stephanmg stephanmg closed this Nov 6, 2023
@stephanmg stephanmg added the invalid This doesn't seem right label Nov 6, 2023
@dweindl dweindl deleted the docker_hub_gha branch April 15, 2024 17:57
@stephanmg stephanmg removed the invalid This doesn't seem right label Nov 13, 2024
@stephanmg stephanmg restored the docker_hub_gha branch November 13, 2024 10:50
@stephanmg stephanmg reopened this Nov 13, 2024
@stephanmg
Copy link
Contributor Author

stephanmg commented Nov 13, 2024

Pull and Run with Docker/Podman:

  1. docker pull ICB-DCM/pyPESTO:latest
  2. docker run --rm ICB-DCM/pyPESTO:latest python -c "import pypesto; print(pypesto.__version__")

With singularity:

  1. singularity pull pyPESTO_latest.sif docker://ICB-DCM/pyPESTO:latest
  2. singularity exec pyPESTO_latest.sif python -c "import pypesto; print(pypesto.__version__")

With apptainer:

  1. apptainer pull pyPESTO_latest.sif docker://ICB-DCM/pyPESTO:latest
  2. singularity exec pyPESTO_latest.sif python -c "import pypesto; print(pypesto.__version__")

@stephanmg stephanmg marked this pull request as ready for review November 13, 2024 14:14
@stephanmg stephanmg changed the title A proposal to deploy latest version of pyPESTO as tagged image to docker hub with GHA Push latest pyPESTO (develop) build as image with tag latest to docker.io Nov 13, 2024
@stephanmg stephanmg self-assigned this Nov 13, 2024
@stephanmg
Copy link
Contributor Author

Somebody with privileges for this repository needs to add two new secrets DOCKER_TOKEN and DOCKER_USERNAME to work.

@stephanmg stephanmg added this pull request to the merge queue Nov 28, 2024
Merged via the queue into develop with commit 7448b92 Nov 28, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants