Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DESeq2 preprocessing #372

Merged
merged 3 commits into from
Nov 8, 2024
Merged

DESeq2 preprocessing #372

merged 3 commits into from
Nov 8, 2024

Conversation

PaulJonasJost
Copy link
Collaborator

Got rid of the main factor.

Q: Do we think for the sake of "nicer code" we should rename formula_sub to just formula?

closes #362

@PaulJonasJost PaulJonasJost requested a review from LeaSeep November 6, 2024 15:36
@PaulJonasJost PaulJonasJost self-assigned this Nov 6, 2024
Copy link
Collaborator

@LeaSeep LeaSeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me its fine in the backend.

We probably want to note that batch effect column is also optional. Maybe just a helptext in the ui?

@PaulJonasJost PaulJonasJost merged commit db2cd09 into develop Nov 8, 2024
1 check passed
@PaulJonasJost PaulJonasJost deleted the DESeq2_removal branch November 8, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants