Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build goal moved to package and major version update #253

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

Khushboo-Sharma-110597
Copy link
Contributor

@Khushboo-Sharma-110597 Khushboo-Sharma-110597 commented Dec 9, 2024

In Maven Bundle Plugin version 2.0.0 we moved the binding of the build goal from the compile phase to the package phase
#197

@davenice
Copy link
Contributor

Your sign-off needs to be on the second-line, @Khushboo-Sharma-110597 - probably need to do it from the command-line (with -s is the easiest way generally).

Also - do we want to go straight out with this or go to -SNAPSHOT first? I don't think we have anyone waiting specifically for it but equally we don't have another release scheduled imminently? @ind1go / @stewartfrancis ?

@davenice
Copy link
Contributor

Also please pop something in the description and link back the issue - I think we have one?

@ind1go
Copy link
Member

ind1go commented Dec 19, 2024

Yeah, we would usually leave the release for a separate PR once we've made a decision to release all the things that have changed.

Especially for a major-version update like this, it'll give us time to take stock and ensure we've rolled any additional breaking changes in, and ensure we have the right level of collateral to support migration.

However, it would definitely be appropriate to move the versions to 2.0.0-SNAPSHOT, to represent the fact that breaking changes have entered the branch and so the next release naturally becomes 2.0.0.

@Khushboo-Sharma-110597 Khushboo-Sharma-110597 force-pushed the move-build-goal-to-package-phase branch from 2f66067 to d43890a Compare December 20, 2024 07:17
@Khushboo-Sharma-110597
Copy link
Contributor Author

I have done the required changes kindly review @davenice @ind1go

Copy link
Contributor

@davenice davenice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! :-D

@Khushboo-Sharma-110597 Khushboo-Sharma-110597 merged commit 06ca10f into main Dec 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants