Don't default 'defaultJVMServer'. #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… overrides Signed-off-by: Stewart Francis <[email protected]>
stewartfrancis
force-pushed
the
defaultjvmserver-fail
branch
from
95f7742 to
aae743e
Compare
davenice
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defaultjvmservertoMYJVMSwhen using thebuildgoalNote that we can't make it "required" because you can specifically supply the jvm server for each bundle part and not have a default at all
There's actually no documentation of how to do this. I'm reluctant to add it right now!
buildgoal but don't specify the bundle path at allFixes #250