Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update junctions.py #409

Closed
wants to merge 1 commit into from
Closed

Update junctions.py #409

wants to merge 1 commit into from

Conversation

djorgen-ibm
Copy link
Collaborator

removed the replacement of '_' with '-' for remote_http_header from the existing junction.

removed the replacement of '_' with '-' for remote_http_header from the existing junction.
@djorgen-ibm djorgen-ibm linked an issue Feb 7, 2024 that may be closed by this pull request
@tombosmansibm
Copy link
Collaborator

I think this is necessary because of a difference between input and output parameters (output is iv_user, input is iv-user).
See https://ibm-security.github.io/apidocs/verifyaccess/10.0.7.0/ISVA-mgmt-rest-api/index.html

@tombosmansibm
Copy link
Collaborator

tombosmansibm commented Feb 8, 2024

So the fix is the expansion of all -> list needs to have the '-' syntax.

                if remote_http_header is None or remote_http_header == []:
                    jct_json['remote_http_header'] = 'do not insert'
                elif isinstance(remote_http_header, basestring) and remote_http_header.lower() == 'all':
                    jct_json['remote_http_header'] = ['iv-creds', 'iv-groups', 'iv-user']

@tombosmansibm
Copy link
Collaborator

I've rewritten the compare functions for the junctions.py and junctions_server.py -> #411

"all" (as string or as array) is now handled differently -> it's sent to the API now (instead of translating it first).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remote_http_header's value in Junction set
2 participants