handle bad requests and crashes

IABTechLab · Nov 8, 2024 · f3ef70d · f3ef70d
1 parent fd31cb8
commit f3ef70d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/routes/index.ts b/src/routes/index.ts
@@ -55,10 +55,18 @@ const EmailPromptRequest = z.object({
 });
 
 const handleEmailPromptSubmission: RequestHandler<{}, z.infer<typeof EmailPromptRequest>> = async (req, res, _next) => {
+  try {
+    EmailPromptRequest.parse(req.body);
+  } catch (e) {
+    logger.log('error', 'error while parsing the request');
+    _next(createError(500));
+    return;
+  }
   const {
     email, countryCode, phone, recaptcha, idType,
   } = EmailPromptRequest.parse(req.body);
 
+
   let idInput = '';
   if (ID_TYPE === 'EUID') {
     if (!isValidEmail(email)) {
@@ -146,7 +154,7 @@ const defaultRouteHandler: RequestHandler<{}, {}, z.infer<typeof DefaultRouteReq
   try {
     requestStep = DefaultRouteRequest.parse(req.body).step; 
   } catch (e) {
-    logger.log('error', 'error while parsing the request');
+    logger.log('error', 'error while parsing step');
     next(createError(500));
     return;
   }

diff --git a/src/utils/logging.ts b/src/utils/logging.ts
@@ -10,6 +10,10 @@ const logger = createLogger({
     }),
   ],
 });
+logger.exceptions.handle(new winston.transports.Console({
+  level: isProduction ? 'info' : 'debug',
+}));
+logger.exitOnError = false;
 
 const headersToRedact = ['authorization', 'authentication'];