Consolidate the Attestation exceptions to retryable or AttestationFailure #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ian-Nara
reviewed
Oct 14, 2024
| @@ -285,6 +285,9 @@ | |||
| <groupId>org.apache.maven.plugins</groupId> | |||
| <artifactId>maven-surefire-plugin</artifactId> | |||
| <version>3.2.5</version> | |||
| <configuration> | |||
| <argLine>-XX:+EnableDynamicAgentLoading</argLine> | |||
There was a problem hiding this comment.
It removes the warning when the tests start that come from mockito.
Ian-Nara
reviewed
Oct 14, 2024
| assertEquals(expectedExceptionMessage, result.getMessage()); | ||
| } | ||
|
|
||
| @Test | ||
| public void Download_Attest401_AttestCalledTwice() throws CloudStorageException, IOException, InterruptedException, AttestationResponseHandlerException { | ||
| public void Download_Attest401_getOptOut_NotCalled() throws CloudStorageException, IOException, AttestationResponseHandlerException { |
There was a problem hiding this comment.
What change is this test update related to?
There was a problem hiding this comment.
I removed the code that calls attest a second time after the first one returns a 401 as that code is not used in production (we log if it is called), and if it returns a 401, calling a second time will get the same response. That test then failed as it checks for 2 calls. Renamed the test as the thing it should be checking is that we don't call getOptOut after getting a 401
Ian-Nara
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.