differentiate 401 with 500 #159
Merged
+162
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasm-ttd
reviewed
Nov 16, 2023
src/main/java/com/uid2/shared/secure/azurecc/PolicyValidator.java
Outdated
Show resolved
Hide resolved
src/main/java/com/uid2/shared/secure/azurecc/MaaTokenSignatureValidator.java
Show resolved
Hide resolved
thomasm-ttd
reviewed
Nov 20, 2023
thomasm-ttd
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error handling logic is on core: https://github.com/IABTechLab/uid2-core/blob/c62c6400a50f121996dd00d85957d59940bebd00/src/main/java/com/uid2/core/vertx/CoreVerticle.java#L237
AyncResultfailed, it will return 500AsyncResultsucceeds, but theAttestationResultfailed, it will return 401 with reason.AttestationResultsucceeds, it will return 200.It would be an overkill to define all error enum in
AttestationFailure. Hence I added addtionalAttestationClientExceptionfield inAttestationResult. If it's not null, we will get failure reason from its error message.This change will impact new GCP attestation provider and new Azure attestation provider. Other attestation provider will not be impacted.