Add description and visible flag to sites #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-yau-ttd
commented
Nov 3, 2023
alex-yau-ttd
commented
Nov 6, 2023
gmsdelmundo
reviewed
Nov 6, 2023
- Use ObjectMapper in SiteParser - Set some propery defaults at the class level - they were done in the old parser - Defend against nulls
This constructor will be used when creating a new site via admin.
gmsdelmundo
reviewed
Nov 7, 2023
- Remove safe equality check from description - Formatting
- Use ObjectMapper in the tests - Fix domains JsonProperty
gmsdelmundo
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
descriptionandvisibletoSite, including setters, getters and method overridesSiteParserSee IABTechLab/uid2-admin#173 for relevant changes in admin