Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operator plaintext key field removal #135

Merged
merged 11 commits into from
Sep 27, 2023
Merged

Operator plaintext key field removal #135

merged 11 commits into from
Sep 27, 2023

Conversation

gmsdelmundo
Copy link
Contributor

@gmsdelmundo gmsdelmundo commented Sep 21, 2023 •
edited
Loading

  • Removed the key field from OperatorKey class.
  • ObjectMapperFactory has also been updated to the Mapper class as a singleton (taken from uid2-validator repo) to reduce number of repeated instantiation.
  • Related OperatorKey assertions have also been updated to use ObjectMapper to better match actual OperatorKey deserialisation in the code.

@gmsdelmundo gmsdelmundo merged commit b6571a9 into master Sep 27, 2023
@gmsdelmundo gmsdelmundo deleted the gdm-UID2-1504-operator-plaintext-key-field-removal branch September 27, 2023 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishalegbert-ttd vishalegbert-ttd vishalegbert-ttd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gmsdelmundo @vishalegbert-ttd