Change UID2-Shared for OptOut Policy Check #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaiweidu
force-pushed
the
zdu-UID2-1863-Change-UID2-Shard-for-opt-out-policy-check
branch
from
71c7834 to
b1a55c1
Compare
zaiweidu
force-pushed
the
zdu-UID2-1863-Change-UID2-Shard-for-opt-out-policy-check
branch
from
8fed857 to
4897aef
Compare
| List<ClientKey> keys = reader.getSnapshot().values().stream() | ||
| .filter(k -> k.getSiteId() == siteId) // filter by site id | ||
| .sorted(Comparator.comparing(ClientKey::getCreated)) // sort by key creation timestamp ascending | ||
| .collect(Collectors.toList()); |
There was a problem hiding this comment.
Would findFirst() be more appropriate here?
There was a problem hiding this comment.
Replaced get(0) with findFirst() as suggested.
| @@ -93,4 +95,12 @@ public CloudPath getMetadataPath() { | |||
| public IAuthorizable get(String key) { | |||
| return getClientKey(key); | |||
| } | |||
|
|
|||
| public ClientKey getOldestClientKey(int siteId) { | |||
There was a problem hiding this comment.
Should this be a method on the snapshot instead? This is not really specific to the rotating provider.
There was a problem hiding this comment.
Per our slack discussion, we'll keep getOldestClientKey() here, and refactor RotatingClientKeyProvider in UID2-1901
|
|
||
| public class RotatingClientKeyProviderTest { | ||
| @Test | ||
| public void testGetOldestClientKeyBySiteId() throws Exception { |
There was a problem hiding this comment.
A test for when site does not have any keys?
There was a problem hiding this comment.
Test case added as suggested.
zaiweidu
force-pushed
the
zdu-UID2-1863-Change-UID2-Shard-for-opt-out-policy-check
branch
from
4897aef to
e47848f
Compare
zaiweidu
changed the title
zaiweidu
changed the title
zaiweidu
force-pushed
the
zdu-UID2-1863-Change-UID2-Shard-for-opt-out-policy-check
branch
from
4d8bdd3 to
d434c01
Compare
zaiweidu
force-pushed
the
zdu-UID2-1863-Change-UID2-Shard-for-opt-out-policy-check
branch
from
595af36 to
66f6cf6
Compare
atarassov-ttd
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getOldestClientKey()to RotatingClientKeyProvider.java