-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show participant is sharing with DSP when allow_sites is null #207
Show participant is sharing with DSP when allow_sites is null #207
Conversation
loadSharingList(); | ||
}, [loadSharingList]); | ||
}, [throwError]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should provide a better error experience here - if there's a 404 from the admin service, we know exactly what's wrong. Just dumping the user to an error where they can't even see the menu any more isn't the right move.
setShowErrorDialog(true); | ||
return; | ||
} | ||
throwError(e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if there is any other ApiError for this get request, I think we should still show error page
I'm merging this as it's approved now, but Jingyi is unavailable at the moment. |
Description:
/api/sharing/list/
return 404 (I believe we should hide sharing permission from menu for this case, but I think there is a separate ticket for this already.)As discussed, when a participant is GENERATOR or SHARER or has a client_keypair, admin service creates a keyset for it. For now we don't allow user create keyset from portal
Required PR:
Manual tests
allow_sites
set to[]
after click save in bulk permissioncompletedRecommendations
to true from DB, it should show shared with DSP