Ian UID2-3703 retrieve configs from identity service #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etrieve' into ian-UID2-3703-identity-service-retrieve
…etrieve' into ian-UID2-3703-identity-service-retrieve
…etrieve' into ian-UID2-3703-identity-service-retrieve
…etrieve' into ian-UID2-3703-identity-service-retrieve
…etrieve' into ian-UID2-3703-identity-service-retrieve
…etrieve' into ian-UID2-3703-identity-service-retrieve
…etrieve' into ian-UID2-3703-identity-service-retrieve
…etrieve' into ian-UID2-3703-identity-service-retrieve
…etrieve' into ian-UID2-3703-identity-service-retrieve
…etrieve' into ian-UID2-3703-identity-service-retrieve
…etrieve' into ian-UID2-3703-identity-service-retrieve
thomasm-ttd
approved these changes
Jul 24, 2024
cYKatherine
reviewed
Jul 24, 2024
| # -- replace base URLs if both CORE_BASE_URL and OPTOUT_BASE_URL are provided | ||
| # -- using hardcoded domains is fine because they should not be changed frequently | ||
| if [ -n "${CORE_BASE_URL}" ] && [ -n "${OPTOUT_BASE_URL}" ] && [ "${DEPLOYMENT_ENVIRONMENT}" != "prod" ]; then | ||
| if [ -n "${CORE_BASE_URL}" ] && [ "${CORE_BASE_URL}" != "null" ] && [ -n "${OPTOUT_BASE_URL}" ] && [ "${OPTOUT_BASE_URL}" != "null" ] && [ "${DEPLOYMENT_ENVIRONMENT}" != "prod" ]; then |
There was a problem hiding this comment.
Intereting, why do we need to check null again? Does -n not checking null?
There was a problem hiding this comment.
jq will return "null" if the key is not found
cYKatherine
reviewed
Jul 24, 2024
| @@ -8,12 +8,12 @@ socks5h-proxy: | |||
| operator-service: | |||
| service: direct | |||
| listen: tcp://0.0.0.0:80 | |||
| connect: vsock://42:8080 | |||
| connect: vsock://16:8080 | |||
There was a problem hiding this comment.
why are we changing this?
There was a problem hiding this comment.
eks/pod/entrypoint.sh has
CID=16
looks that @thomasm-ttd picked this number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.