add unit tests for policy specification #211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -738,6 +738,51 @@ void tokenGenerateNoEmailOrHashSpecified(String apiVersion, Vertx vertx, VertxTe | |||
| }); | |||
| } | |||
|
|
|||
| @Test | |||
| void tokenGenerateNewParticipantNoPolicySpecified(Vertx vertx, VertxTestContext testContext) { | |||
There was a problem hiding this comment.
Are these tests covering the right things given that the parent PR is not using the new oldest key function from uid2-shared?
There was a problem hiding this comment.
I have updated the unit test for this change
zaiweidu
force-pushed
the
zdu-UID2-1776-Add-policy-check-for-Publisher
branch
from
1256174 to
6cfbbe5
Compare
…UID2-1778-unit-test-optout-policy # Conflicts: # src/main/java/com/uid2/operator/vertx/UIDOperatorVerticle.java
|
This PR was combined with #207 and merged into Master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New tests to validate desire behavior:
Existing tests to validate desired behavior: