Cbc UI d2 4454 cloud encryption operator #1175
Conversation
…hat's going on with auth
…into cbc-UID2-4454-cloud-encryption-operator
|
|
||
| @Override | ||
| public long getVersion(JsonObject metadata) { | ||
| return Instant.now().getEpochSecond(); |
There was a problem hiding this comment.
why isn't it metadata.getLong("version") ?
There was a problem hiding this comment.
Because this is using an API to get the data not a file, so there is no metadata to look the version up in. So I just used the time here to force a refresh everytime
There was a problem hiding this comment.
This probably needs a comment explaining why you are doing this as I feel we will forget
| public class RotatingCloudEncryptionKeyApiProvider extends RotatingCloudEncryptionKeyProvider { | ||
| private static final Logger LOGGER = LoggerFactory.getLogger(RotatingCloudEncryptionKeyApiProvider.class); | ||
|
|
||
| public ApiStoreReader<Map<Integer, CloudEncryptionKey>> apiStoreReader; |
There was a problem hiding this comment.
does this need to be public?
| @@ -0,0 +1,73 @@ | |||
| [ { | |||
There was a problem hiding this comment.
Indentation format like this: https://github.com/IABTechLab/uid2-admin/blob/main/src/main/resources/localstack/s3/core/keys/keys.json?
|
|
||
| @Override | ||
| public long getVersion(JsonObject metadata) { | ||
| return Instant.now().getEpochSecond(); |
There was a problem hiding this comment.
This probably needs a comment explaining why you are doing this as I feel we will forget
| .put(dataType, new JsonArray().add("value1").add("value2")); | ||
|
|
||
| List<TestData> expectedData = Arrays.asList(new TestData("value1"), new TestData("value2")); | ||
| when(mockParser.deserialize(any(InputStream.class))) |
There was a problem hiding this comment.
This test doesn't actually test if the input "contents" are used to return the result. It is only testing that loadContent will store the results of the parser.deserialize in the snapshot. I could change the contents array to have 3 values and the test would still pass.
You should validate properties of the any(InputStream.class) parameter.
…IABTechLab/uid2-operator into cbc-UID2-4454-cloud-encryption-operator
| try { | ||
| JsonArray dataArray = contents.getJsonArray(dataType); | ||
| if (dataArray == null) { | ||
| throw new IllegalArgumentException("No array found in the contents"); |
There was a problem hiding this comment.
Would it be useful to include the dataType in the error message?
No description provided.