Addressing last PR comments and updating shared

IABTechLab · Jan 9, 2025 · 233d9aa · 233d9aa
1 parent 5163db8
commit 233d9aa
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/pom.xml b/pom.xml
@@ -22,7 +22,7 @@
         <enclave-aws.version>2.1.0</enclave-aws.version>
         <enclave-azure.version>2.1.0</enclave-azure.version>
         <enclave-gcp.version>2.1.0</enclave-gcp.version>
-        <uid2-shared.version>8.0.15-alpha-177-SNAPSHOT</uid2-shared.version>
+        <uid2-shared.version>8.0.25</uid2-shared.version>
         <image.version>${project.version}</image.version>
         <maven.compiler.source>21</maven.compiler.source>
         <maven.compiler.target>21</maven.compiler.target>

diff --git a/src/main/java/com/uid2/operator/reader/ApiStoreReader.java b/src/main/java/com/uid2/operator/reader/ApiStoreReader.java
@@ -36,7 +36,7 @@ public long loadContent(JsonObject contents, String dataType) throws IOException
         try {
             JsonArray dataArray = contents.getJsonArray(dataType);
             if (dataArray == null) {
-                throw new IllegalArgumentException("No array found in the contents");
+                throw new IllegalArgumentException(String.format("No array of type: %s, found in the contents", dataType));
             }
 
             String jsonString = dataArray.toString();

diff --git a/src/main/java/com/uid2/operator/reader/RotatingCloudEncryptionKeyApiProvider.java b/src/main/java/com/uid2/operator/reader/RotatingCloudEncryptionKeyApiProvider.java
@@ -27,6 +27,7 @@ public RotatingCloudEncryptionKeyApiProvider(DownloadCloudStorage fileStreamProv
 
     @Override
     public long getVersion(JsonObject metadata) {
+        // Since we are pulling from an api not a data file, we use the epoch time we got the keys as the version
         return Instant.now().getEpochSecond();
     }
 }
diff --git a/src/test/java/com/uid2/operator/ApiStoreReaderTest.java b/src/test/java/com/uid2/operator/ApiStoreReaderTest.java
@@ -61,7 +61,7 @@ void loadContentThrowsExceptionWhenArrayNotFound() {
             JsonObject contents = new JsonObject();
             assertThatThrownBy(() -> reader.loadContent(contents))
                     .isInstanceOf(IllegalArgumentException.class)
-                    .hasMessageContaining("No array found in the contents");
+                    .hasMessageContaining("No array of type: test-data-type, found in the contents");
         }
 
         @Test