check operator version and provide correct presigned url #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizk886
changed the title
Ian-Nara
reviewed
Jul 24, 2024
lizk886
changed the base branch from
main
to
wzh-uid2-3572-s3encryption-keys-distribution-endpoint
thomasm-ttd
reviewed
Aug 1, 2024
Base automatically changed from
wzh-uid2-3572-s3encryption-keys-distribution-endpoint
to
main
August 1, 2024 21:12
…hub.com:IABTechLab/uid2-core into wzh-uid2-3574-check-version-update-presignedurl
thomasm-ttd
approved these changes
Nov 8, 2024
conf/default-config.json
Outdated
| @@ -17,5 +17,6 @@ | |||
| "att_token_enc_key": null, | |||
| "att_token_enc_salt": null, | |||
| "enforceJwt": false, | |||
| "s3_keys_metadata_path": null | |||
| "s3_keys_metadata_path": null, | |||
There was a problem hiding this comment.
Do not forget to add this in the uid2-operator-deployment repo. Suggest you add that before you merge this
pom.xml
Outdated
| @@ -109,6 +109,11 @@ | |||
| <version>5.2.0</version> | |||
| <scope>test</scope> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
What does byte-buddy do?
Ian-Nara
reviewed
Nov 26, 2024
| assertEquals("error generating attestation token", json2.getString("message")); | ||
| JsonObject json2 = response2.bodyAsJsonObject(); | ||
| assertEquals("error", json2.getString("status")); | ||
| assertEquals("error generating attestation token", json2.getString("message")); |
There was a problem hiding this comment.
whats up with indentation here?
Ian-Nara
approved these changes
Nov 26, 2024
cody-constine-ttd
deleted the
wzh-uid2-3574-check-version-update-presignedurl
branch
cody-constine-ttd
restored the
wzh-uid2-3574-check-version-update-presignedurl
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solution 2: get upgraded info by comparing version info in headers. With unit tests.
need to deploy IABTechLab/uid2-shared#314 first ( update the Const.java)
successful build: https://github.com/IABTechLab/uid2-core/actions/runs/10288910692
successful run in integration: