fix: tweak services.yaml values #1004
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Max time -> 15 minutes Switch strings for steering wheel and seat heaters to numbers. Clarify messaging around accessory heating.
|
I don't recall the exact reason but I believe if the numbers aren't in quotes an error occurs on 0. Have you been able to test this? |
|
I didn't try with 0 but I did test with other values. I'll give it a try. Another way to deal with this would be to coerce the values from strings to ints in the backend code. At least for Kia USA it doesn't do this and strings in the JSON don't work. |
|
max duration for my kia ev9 is 30 minutes |
It's 30 minutes for Kia EV6 2025 as well |
|
Looks like hassfest check is failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Max time -> 15 minutes
Switch strings for steering wheel and seat heaters to numbers. Clarify messaging around accessory heating.