Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: OPTIC-1540: Add stale ff new batch #6922

Merged
merged 4 commits into from
Jan 23, 2025

Conversation

luarmr
Copy link
Contributor

@luarmr luarmr commented Jan 16, 2025

Add a set of feature flag to stale state. This will allow us to remove them safely in the future.

Please review the status of the FF flag in LaunchDarkly. Only one is set to false.

Copy link

netlify bot commented Jan 16, 2025

Deploy Preview for label-studio-docs-new-theme ready!

Name Link
🔨 Latest commit ed93db4
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/678eac1c564f040008d4b871
😎 Deploy Preview https://deploy-preview-6922--label-studio-docs-new-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 16, 2025

Deploy Preview for heartex-docs ready!

Name Link
🔨 Latest commit ed93db4
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/678eac1cff52cb000883f473
😎 Deploy Preview https://deploy-preview-6922--heartex-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.95%. Comparing base (71c94c8) to head (ed93db4).
Report is 27 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6922   +/-   ##
========================================
  Coverage    76.95%   76.95%           
========================================
  Files          175      175           
  Lines        14144    14144           
========================================
  Hits         10884    10884           
  Misses        3260     3260           
Flag Coverage Δ
pytests 76.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luarmr luarmr requested review from makseq and hlomzik January 17, 2025 21:06
@luarmr luarmr requested a review from Gondragos January 17, 2025 22:13
@AndrejOros
Copy link
Contributor

AndrejOros commented Jan 20, 2025

/git merge

Workflow run
Successfully merged: create mode 100644 web/libs/editor/src/utils/billing.ts

Copy link
Collaborator

@hlomzik hlomzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to leave LEAP-443 FF untouched for now and investigate what's wrong

label_studio/core/feature_flags/stale_feature_flags.py Outdated Show resolved Hide resolved
@luarmr luarmr merged commit 7cff2a8 into develop Jan 23, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants