-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: OPTIC-1407: Optimize the tasks API paginated prediction and annotation totals #6735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6735 +/- ##
===========================================
- Coverage 76.73% 76.70% -0.04%
===========================================
Files 170 170
Lines 13885 13919 +34
===========================================
+ Hits 10655 10676 +21
- Misses 3230 3243 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
triklozoid
reviewed
Nov 29, 2024
mcanu
reviewed
Nov 29, 2024
mcanu
reviewed
Nov 29, 2024
triklozoid
approved these changes
Nov 29, 2024
mcanu
approved these changes
Nov 29, 2024
AndrejOros
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made
ex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
Change has impacts in these area(s)
(check all that apply)
Describe the reason for change
At larger counts of tasks and annotations, these 2 queries would become incredibly inefficient and cause slowdowns. This PR instead uses the task column values to do aggregation and simple SUM's on the values to produce the same output.
Does this change affect performance?
Improves performance about 15-20x when looking at volumes of data where there are greater than 500K tasks, and 500K annotations per project.
What alternative approaches were there?
What feature flags were used to cover this change?
fflag_fix_back_optic_1407_optimize_tasks_api_pagination_counts
Does this PR introduce a breaking change?
(check only one)
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
Tasks List API