Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DIA-1451: return list instead of generator #268

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pakelley
Copy link
Contributor

@pakelley pakelley commented Dec 2, 2024

No description provided.

@robot-ci-heartex robot-ci-heartex temporarily deployed to fb-dia-1451 December 2, 2024 22:34 Destroyed
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.02%. Comparing base (ed9e277) to head (f7969a2).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
adala/skills/collection/label_studio.py 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #268      +/-   ##
==========================================
- Coverage   68.05%   68.02%   -0.03%     
==========================================
  Files          47       47              
  Lines        2504     2508       +4     
==========================================
+ Hits         1704     1706       +2     
- Misses        800      802       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robot-ci-heartex robot-ci-heartex marked this pull request as draft December 3, 2024 09:06
@pakelley pakelley marked this pull request as ready for review December 3, 2024 17:32
@robot-ci-heartex robot-ci-heartex temporarily deployed to fb-dia-1451 December 3, 2024 17:35 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants