Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DIA-1660: Adala errors are not reported as ConstrainedGenerationError when they should be #259

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

matt-bernstein
Copy link
Contributor

Instructor upstream error handling has changed

  • ValidationErrors don't contain the string we were checking with multiskill
  • instructor bug leads to them sometimes being reported as AttributeError

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.49%. Comparing base (95fa429) to head (2512959).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
+ Coverage   66.36%   66.49%   +0.12%     
==========================================
  Files          47       47              
  Lines        2447     2462      +15     
==========================================
+ Hits         1624     1637      +13     
- Misses        823      825       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

adala/runtimes/_litellm.py Outdated Show resolved Hide resolved
@matt-bernstein matt-bernstein merged commit 67669ef into master Nov 21, 2024
11 checks passed
@matt-bernstein matt-bernstein deleted the fb-dia-1660 branch November 21, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants