Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: refactor argument passing in icon's starlark and Go packages for starting node #195

Merged
merged 2 commits into from
Oct 10, 2023
Merged

refactor: refactor argument passing in icon's starlark and Go packages for starting node #195

merged 2 commits into from
Oct 10, 2023

Conversation

abhiyana
Copy link
Contributor

Description:

Commit Message

refactor: refactor argument passing in icon's Starlark and Go packages for starting node

see the guidelines for commit messages.

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@shreyasbhat0 shreyasbhat0 merged commit ecabd48 into args-refactor Oct 10, 2023
hemz10 pushed a commit that referenced this pull request Oct 18, 2023
@shreyasbhat0 @abhiyana
perf: refactor args in dive starlark package (#198)
a47f7e7 
* refactor: refactor argument passing in the starlark and go package of neutron and archway (#191)

* refactor: refactor argument passing in the starlark and go package of neutron and archway

* chore: remove print statement

* chore: remove services json

* chore: format document

* ref: update doc strings  and formatting

* chore: update string

---------

Co-authored-by: shreyasbhat0 <[email protected]>

* refactor: refactor argument passing in eth's starlark and go package (#192)

* refactor: refactor argument passing in ets's starlark and Go packages

* refactor: refactor argument passing in eth's contract configuration starlark and Go packages

* refactor: add doc strings in eth starlark package

* refactor: refactor argument passing in icon's starlark and Go packages for starting node (#195)

* refactor: refactor argument passing in icon's starlark and Go packages

* chore:change DiveRemotePackagePath in constant.go and RunStarlarkPackage to RunStarlarkRemotePackage in icon.go

* refactor:  refactor icon's, eth's, btp, ibc bridge  kurtosis and go package of contract configuration, bridge btp (#197)

* refactor: refactor argument passing in icon's starlark and Go packages

* chore:change DiveRemotePackagePath in constant.go and RunStarlarkPackage to RunStarlarkRemotePackage in icon.go

* refactor: refactor argument passing  in icon's, eth's btp  setup starklark package

* refactor:  refactor icon's, eth's, btp, ibc bridge  kurtosis and go package of contract configuration, bridge btp

* refactor: refactor args in main.star and move setup ibc function from main.star to bridge.star (#199)

* refactor: refactor argument passing in icon's starlark and Go packages

* chore:change DiveRemotePackagePath in constant.go and RunStarlarkPackage to RunStarlarkRemotePackage in icon.go

* refactor: refactor argument passing  in icon's, eth's btp  setup starklark package

* refactor:  refactor icon's, eth's, btp, ibc bridge  kurtosis and go package of contract configuration, bridge btp

* fix: fix error getting while running single icon node through cli

* refactor: refactor args inside main.star and moving btp, ibc setup function in bridge.star respectively

* refactor: remove unnecessary spaces beween code lines

* refactor: remove unnecessary code from input_parser.star and main.star (#201)

* refactor: refactor argument passing in icon's starlark and Go packages

* chore:change DiveRemotePackagePath in constant.go and RunStarlarkPackage to RunStarlarkRemotePackage in icon.go

* refactor: refactor argument passing  in icon's, eth's btp  setup starklark package

* refactor:  refactor icon's, eth's, btp, ibc bridge  kurtosis and go package of contract configuration, bridge btp

* fix: fix error getting while running single icon node through cli

* refactor: refactor args inside main.star and moving btp, ibc setup function in bridge.star respectively

* refactor: remove unnecessary spaces beween code lines

* refactor: removing unnecessary code from main.star and bridge.star

* refactor: remove unnecessary code from input_parser.star

---------

Co-authored-by: Abhishek Harde <[email protected]>
shreyasbhat0 added a commit that referenced this pull request Jan 24, 2024
@shreyasbhat0 @abhiyana
perf: refactor args in dive starlark package (#198)
076867f 
* refactor: refactor argument passing in the starlark and go package of neutron and archway (#191)

* refactor: refactor argument passing in the starlark and go package of neutron and archway

* chore: remove print statement

* chore: remove services json

* chore: format document

* ref: update doc strings  and formatting

* chore: update string

---------

Co-authored-by: shreyasbhat0 <[email protected]>

* refactor: refactor argument passing in eth's starlark and go package (#192)

* refactor: refactor argument passing in ets's starlark and Go packages

* refactor: refactor argument passing in eth's contract configuration starlark and Go packages

* refactor: add doc strings in eth starlark package

* refactor: refactor argument passing in icon's starlark and Go packages for starting node (#195)

* refactor: refactor argument passing in icon's starlark and Go packages

* chore:change DiveRemotePackagePath in constant.go and RunStarlarkPackage to RunStarlarkRemotePackage in icon.go

* refactor:  refactor icon's, eth's, btp, ibc bridge  kurtosis and go package of contract configuration, bridge btp (#197)

* refactor: refactor argument passing in icon's starlark and Go packages

* chore:change DiveRemotePackagePath in constant.go and RunStarlarkPackage to RunStarlarkRemotePackage in icon.go

* refactor: refactor argument passing  in icon's, eth's btp  setup starklark package

* refactor:  refactor icon's, eth's, btp, ibc bridge  kurtosis and go package of contract configuration, bridge btp

* refactor: refactor args in main.star and move setup ibc function from main.star to bridge.star (#199)

* refactor: refactor argument passing in icon's starlark and Go packages

* chore:change DiveRemotePackagePath in constant.go and RunStarlarkPackage to RunStarlarkRemotePackage in icon.go

* refactor: refactor argument passing  in icon's, eth's btp  setup starklark package

* refactor:  refactor icon's, eth's, btp, ibc bridge  kurtosis and go package of contract configuration, bridge btp

* fix: fix error getting while running single icon node through cli

* refactor: refactor args inside main.star and moving btp, ibc setup function in bridge.star respectively

* refactor: remove unnecessary spaces beween code lines

* refactor: remove unnecessary code from input_parser.star and main.star (#201)

* refactor: refactor argument passing in icon's starlark and Go packages

* chore:change DiveRemotePackagePath in constant.go and RunStarlarkPackage to RunStarlarkRemotePackage in icon.go

* refactor: refactor argument passing  in icon's, eth's btp  setup starklark package

* refactor:  refactor icon's, eth's, btp, ibc bridge  kurtosis and go package of contract configuration, bridge btp

* fix: fix error getting while running single icon node through cli

* refactor: refactor args inside main.star and moving btp, ibc setup function in bridge.star respectively

* refactor: remove unnecessary spaces beween code lines

* refactor: removing unnecessary code from main.star and bridge.star

* refactor: remove unnecessary code from input_parser.star

---------

Co-authored-by: Abhishek Harde <[email protected]>
@shreyasbhat0 shreyasbhat0 deleted the DIVE-159-Code-refactoring-in-icon-starlark-package-of-setup-icon-node branch January 25, 2024 05:56
Mr-Nobody21 pushed a commit to Mr-Nobody21/DIVE that referenced this pull request May 7, 2024
@shreyasbhat0 @abhiyana
perf: refactor args in dive starlark package (HugoByte#198)
d68d45b 
* refactor: refactor argument passing in the starlark and go package of neutron and archway (HugoByte#191)

* refactor: refactor argument passing in the starlark and go package of neutron and archway

* chore: remove print statement

* chore: remove services json

* chore: format document

* ref: update doc strings  and formatting

* chore: update string

---------

Co-authored-by: shreyasbhat0 <[email protected]>

* refactor: refactor argument passing in eth's starlark and go package (HugoByte#192)

* refactor: refactor argument passing in ets's starlark and Go packages

* refactor: refactor argument passing in eth's contract configuration starlark and Go packages

* refactor: add doc strings in eth starlark package

* refactor: refactor argument passing in icon's starlark and Go packages for starting node (HugoByte#195)

* refactor: refactor argument passing in icon's starlark and Go packages

* chore:change DiveRemotePackagePath in constant.go and RunStarlarkPackage to RunStarlarkRemotePackage in icon.go

* refactor:  refactor icon's, eth's, btp, ibc bridge  kurtosis and go package of contract configuration, bridge btp (HugoByte#197)

* refactor: refactor argument passing in icon's starlark and Go packages

* chore:change DiveRemotePackagePath in constant.go and RunStarlarkPackage to RunStarlarkRemotePackage in icon.go

* refactor: refactor argument passing  in icon's, eth's btp  setup starklark package

* refactor:  refactor icon's, eth's, btp, ibc bridge  kurtosis and go package of contract configuration, bridge btp

* refactor: refactor args in main.star and move setup ibc function from main.star to bridge.star (HugoByte#199)

* refactor: refactor argument passing in icon's starlark and Go packages

* chore:change DiveRemotePackagePath in constant.go and RunStarlarkPackage to RunStarlarkRemotePackage in icon.go

* refactor: refactor argument passing  in icon's, eth's btp  setup starklark package

* refactor:  refactor icon's, eth's, btp, ibc bridge  kurtosis and go package of contract configuration, bridge btp

* fix: fix error getting while running single icon node through cli

* refactor: refactor args inside main.star and moving btp, ibc setup function in bridge.star respectively

* refactor: remove unnecessary spaces beween code lines

* refactor: remove unnecessary code from input_parser.star and main.star (HugoByte#201)

* refactor: refactor argument passing in icon's starlark and Go packages

* chore:change DiveRemotePackagePath in constant.go and RunStarlarkPackage to RunStarlarkRemotePackage in icon.go

* refactor: refactor argument passing  in icon's, eth's btp  setup starklark package

* refactor:  refactor icon's, eth's, btp, ibc bridge  kurtosis and go package of contract configuration, bridge btp

* fix: fix error getting while running single icon node through cli

* refactor: refactor args inside main.star and moving btp, ibc setup function in bridge.star respectively

* refactor: remove unnecessary spaces beween code lines

* refactor: removing unnecessary code from main.star and bridge.star

* refactor: remove unnecessary code from input_parser.star

---------

Co-authored-by: Abhishek Harde <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreyasbhat0 shreyasbhat0 shreyasbhat0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhiyana @shreyasbhat0