Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: file upload via relative path #190

Merged
merged 4 commits into from
Oct 4, 2023
Merged

fix: file upload via relative path #190

merged 4 commits into from
Oct 4, 2023

Conversation

shreyasbhat0
Copy link
Contributor

Description:

Commit Message

fix: file upload via relative path

see the guidelines for commit messages.

Changelog Entry

version: Kurtosis SDK Version Bump to 0.84.0

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@hemz10 hemz10 merged commit f659c3b into main Oct 4, 2023
@shreyasbhat0 shreyasbhat0 deleted the fix/update-file-upload branch October 4, 2023 09:31
@shreyasbhat0 shreyasbhat0 mentioned this pull request Oct 4, 2023
Closed
2 tasks
shreyasbhat0 added a commit that referenced this pull request Jan 24, 2024
@shreyasbhat0 @abhiyana
fix: file upload via relative path (#190)
ed216a1 
* fix: constants for file upload

* test: update make file to run archway e2e

* refactor: change default_contract_path for NEUTRON_SERVICE_CONFIG in constant.star

---------

Co-authored-by: hemz10 <[email protected]>
Co-authored-by: abhiyana <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hemz10 hemz10 hemz10 approved these changes

@Mr-Nobody21 Mr-Nobody21 Awaiting requested review from Mr-Nobody21

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shreyasbhat0 @hemz10 @abhiyana