GH-65 # Add playwright traces

Hugo-C · Aug 13, 2024 · e30233c · e30233c
1 parent 16d61f7
commit e30233c
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/.github/workflows/playwright.yml b/.github/workflows/playwright.yml
@@ -14,4 +14,9 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Run playwright test
-        run: docker compose -f docker-compose.playwright.yml run pytest_runner
+        run: docker compose -f docker-compose.playwright.yml run pytest_runner --tracing=retain-on-failure --output=/code/tests/playwright-test-results/
+      - uses: actions/upload-artifact@v4
+        if: ${{ !cancelled() }}
+        with:
+          name: playwright-traces
+          path: tests/playwright-test-results/
diff --git a/.gitignore b/.gitignore
@@ -1,2 +1,4 @@
 /target
-.env  # Expected to contains VUE_APP_SENTRY_DSN and ROCKET_SENTRY_DSN
+.env  # Expected to contains VUE_APP_SENTRY_DSN and ROCKET_SENTRY_DSN
+
+/tests/playwright-test-results/
diff --git a/Makefile b/Makefile
@@ -4,9 +4,7 @@ run_integration_tests:
 	docker compose -f docker-compose.integration.yml down
 
 run_e2e_tests:
-	docker compose -f docker-compose.playwright.yml build jarm_online_gui
-	docker compose -f docker-compose.playwright.yml build jarm_online_api
-	docker compose -f docker-compose.playwright.yml run pytest_runner
+	docker compose -f docker-compose.playwright.yml run pytest_runner --tracing=retain-on-failure --output=/code/tests/playwright-test-results/
 	docker compose -f docker-compose.playwright.yml down
 
 # e2e test with headed browser can't run in docker as a Xserver is required