Some fixes #1
Some fixes #1
Conversation
imnotbob
commented
Sep 23, 2019
imnotbob
commented
- Fixes attribute definitions
- Some attributes are 'composite' in that a single setting enables several attributes that were not defined.
- makes more attributes selectable (reducing default db usage on HE)
- Fixes that lux updates frequently regardless of the poll setting (so can poll slowly, yet lux updates regularly
- Fixes that changes from day to night will update polling more quickly (even if polling is set to long interval)
- automatically turns off debug logging after 30mins as is norm in HE devices
- only update currDate and currTime based on new poll response
- fixes moon phase calculation
- Fixes attribute definitions
- Some attributes are 'composite' in that a single setting enables several attributes that were not defined.
- makes more attributes selectable (reducing default db usage on HE)
- Fixes that lux updates frequently regardless of the poll setting (so can poll slowly, yet lux updates regularly
- Fixes that changes from day to night will update polling more quickly (even if polling is set to long interval)
- automatically turns off debug logging after 30mins as is norm in HE devices
- only update currDate and currTime based on new poll response
- fixes moon phase calculation
There was a problem hiding this comment.
Thanks for the updates. I will incorporate the true corrections and try to address most areas you highlighted. I will not be incorporating what I call 'coding style' changes you made throughout the file. Look for an update when I am done incorporating your changes (I have never done a 'pull request' and since I am not accepting many of your edits, I will just manually incorporate those).
Thanks again!
|
sure. The changes I made reduced the file size 5%...(which in HE matters when compiling) I have one more change I made today to reduce the noise (jitter) in the lux estimation. It causes a lot of needless database updates (and increases in db size) with little benefit given it is an estimation). It is about 5 lines. |
|
Note that on command line (linux, mac) diff -w oldfile newfile gives the diffs without white space changes |
|
Do you have a Hubitat Community handle that I can reference? I would like to credit you for the changes I will release and It does not recognize @imnotbob? Thanks! |
|
I'm nh.schottfam in the HE community. I have another pull request to share with a couple fixes/suggestions. |
