Fix golint #33 #34
Merged
Fix golint #33 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuKeping
reviewed
Jan 20, 2020
iterator.go
Outdated
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| package rbtree | |||
|
|
|||
| // Iterator is the function of iteration entity | |||
There was a problem hiding this comment.
we may add a sample to help people to understand the Iterator type, how about
// Iterator is the function of iteration entity which would be
// used by those functions like `Ascend`, `Dscend`, etc.
//
// A typical Iterator with Print :
// func loop_with_print(item rbtree.Item) bool {
// i, ok := item.(XXX)
// if !ok {
// return false
// }
// fmt.Printf("%+v\n", i)
// return true
// }
HuKeping
reviewed
Jan 20, 2020
rbtree.go
Outdated
| RED = 0 | ||
| // RED represents the color of the node is red | ||
| RED = 0 | ||
| // BLACK represents the color of the node is brack |
rbtree.go
Outdated
| BLACK = 1 | ||
| ) | ||
|
|
||
| // Item has a method to compare its which is less |
stats.go
Outdated
| @@ -41,6 +43,7 @@ func (t *Rbtree) Delete(item Item) Item { | |||
| return t.delete(&Node{t.NIL, t.NIL, t.NIL, RED, item}).Item | |||
| } | |||
|
|
|||
| //Get search the node which includes its node | |||
There was a problem hiding this comment.
how about something like
// Get search for the specified item (which was carried by a Node) in the tree, return nil if not found.
|
Could you please add your sign-off , the rest LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33
I fixed all golint warnings. Almost I fixed the comment of expose items.
it might be misunderstanding those exposed func, var...