#277 [Feat] 컴포즈 SingleEventHandler 구현 및 적용 #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KWY0218
approved these changes
Sep 15, 2023
...main/java/hous/release/android/presentation/our_rules/component/update/RulePhotoStatusBar.kt
Outdated
Show resolved
Hide resolved
KWY0218
approved these changes
Sep 17, 2023
| @@ -33,7 +33,7 @@ fun RuleAddPhotoButton( | |||
| ) { | |||
| val focusManager = LocalFocusManager.current | |||
| Row( | |||
| modifier = Modifier.clickable( | |||
| modifier = Modifier.clickableSingle( | |||
2zerozu
approved these changes
Sep 19, 2023
Comment on lines
+42
to
+54
| SingleEventArea { cutter -> | ||
| FloatingActionButton( | ||
| onClick = { cutter.handle(onClick) }, | ||
| backgroundColor = HousBlue, | ||
| contentColor = HousWhite, | ||
| modifier = Modifier.size(92.dp) | ||
| .padding(16.dp) | ||
| ) { | ||
| Icon( | ||
| imageVector = ImageVector.vectorResource(id = R.drawable.ic_plus), | ||
| contentDescription = "Add" | ||
| ) | ||
| } |
Comment on lines
+9
to
+21
| @OptIn(ExperimentalTime::class) | ||
| internal class ThrottledDurationStrategy : SingleEventHandleStrategy { | ||
| private val currentTime: TimeMark get() = TimeSource.Monotonic.markNow() | ||
| private val throttleDuration: Duration = 300.milliseconds | ||
| private lateinit var lastEventTime: TimeMark | ||
|
|
||
| override fun handle(event: () -> Unit) { | ||
| if (::lastEventTime.isInitialized.not() || (lastEventTime + throttleDuration).hasPassedNow()) { | ||
| event() | ||
| } | ||
| lastEventTime = currentTime | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업한 내용
designsystem/util에 SingleEventHandler 구현designsystem/modifier에 ClickableSingle 구현designsystem/component/user_interaction에 SingleEventArea 컴포저블 구현PR 포인트
1. SingleEventHandler
여러 번 클릭 이벤트를 막아주는 SingleEventHandler입니다.
마지막 이벤트가 발생한 시간이 300ms이 넘어야 이벤트가 발생할 수 있도록 하였습니다.
SingleEventHandlerImpl를 구현할 때 kotlin.time api를 사용했습니다.기존
System.currentTimeMillis()방식보다 훨씬 코드 조작하기도 편하고, 나중에 time이나 Date 관련해서 작업하신다면 적극 이용해보세요!!2. 사용법
SingleEventHandler를 기반으로 Modifier 확장함수와 composable을 만들었습니다.
참고 블로그 - How to prevent multiple clicks in Android Jetpack Compose.
3. 추가 리팩토링
SingleEventHandler를 사용하는 곳이 사용처마다 달라질 수도 있다고 생각이 들어 전략패턴을 사용하여 변경했습니다 ! c2de285
4. 테스트
솔직히 SingleEventHandler는 굳이 테스트 안해도 될 것 같습니다만.. 올만에 mockking해보고 싶어서 했습니다 :D