#313 [fix] Rule dropdown menu Clip radius 값 수정 #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KWY0218
approved these changes
Sep 11, 2023
| private val DropdownDividerPadding = 14.dp | ||
| private val LocalShapes = staticCompositionLocalOf { Shapes() } |
There was a problem hiding this comment.
LocalShapes 변수는 사용 하지 않는 변수일까요?
murjune
force-pushed
the
ui/#313-fix-rule-dropdown-menu
branch
from
1fcd61d to
6f895d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업한 내용
PR 포인트
드롭다운의 clip속성을 바꾸고 싶었는데
DropDownMenu내부적으로 MaterialTheme.shapes.medium을 사용하고 있어서 바꿀 방법이 없었습니다.. 따라서, Shapes 자체를 오버라이딩하는 방법 말고는 해결할 수가 없었네요더 좋은 방법이 있다면 알려주세요!
관련 stackoverflow