Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#308 [feat] 대표 룰 수정 api 및 presentation 로직 #310

Merged
merged 10 commits into from
Sep 9, 2023
Merged

#308 [feat] 대표 룰 수정 api 및 presentation 로직 #310

merged 10 commits into from
Sep 9, 2023

Conversation

murjune
Copy link
Member

@murjune murjune commented Sep 3, 2023 •
edited
Loading

관련 이슈

작업한 내용

Screen_Recording_20230903_181031_Hous-.mp4
  • 대표 룰 수정 api
  • 대표 룰 수정 Usecase
  • HousDot color 기준 변경
  • 대표 룰 Presentation Logic
  • 대표 룰 NavGraph 수정

PR 포인트

@murjune murjune requested review from KWY0218 and 2zerozu September 3, 2023 09:08
@murjune murjune changed the title Feature/#308 represent rule api presentation [feat] 대표 룰 수정 api 및 presentation 로직 Sep 3, 2023
@murjune murjune self-assigned this Sep 3, 2023
@murjune murjune changed the title [feat] 대표 룰 수정 api 및 presentation 로직 #308 [feat] 대표 룰 수정 api 및 presentation 로직 Sep 3, 2023
KWY0218
KWY0218 approved these changes Sep 3, 2023
View reviewed changes
Copy link
Member

@KWY0218 KWY0218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

구웃 ~ ! 👍

...rc/main/java/hous/release/android/presentation/our_rules/viewmodel/RepresentRuleViewModel.kt Outdated
Comment on lines 45 to 47

val isSavable get() = uiState.value.rules == uiState.value.originRules

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오.. 항상 combine 사용했었는데 이런 식으로 짧게도 가능하네요... 👍

murjune added a commit that referenced this pull request Sep 5, 2023
@murjune
Merge remote-tracking branch 'origin/develop' into feature/#310-repre…
445f4e0 
…sentation-rule-ui-presentation
murjune added a commit that referenced this pull request Sep 5, 2023
@murjune
#310 [fix] HousCheckBox - isChecked, onCheckedChanged defaultValue 삭제
b0b3014
2zerozu
2zerozu approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@2zerozu 2zerozu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview1,2,3,4 이렇게 네이밍해도 괜찮은 건가요?? (컴알못...)

@2zerozu 2zerozu added 준원🐻 준원이가 작업함! feat 새로운 기능 추가 Pull Request🔥 풀리퀘 날림! labels Sep 5, 2023
murjune added a commit that referenced this pull request Sep 9, 2023
@murjune
#310 [chore] 기존의 check icon, selector 삭제 후 design system에 생성
2c981f6
murjune added a commit that referenced this pull request Sep 9, 2023
@murjune
#310 [ui(designSystem)] HousCheckBox Component
822cfec
murjune added a commit that referenced this pull request Sep 9, 2023
@murjune
#310 [Chore] 패키징 및 컴포넌트 분리
edcb936
murjune added a commit that referenced this pull request Sep 9, 2023
@murjune
#310 [Delete] DeleteRuleScreen
58e5c09
murjune added a commit that referenced this pull request Sep 9, 2023
@murjune
#310 [add] 대표 룰 UIModel
7952cc4
murjune added a commit that referenced this pull request Sep 9, 2023
@murjune
#310 [chore] lint 추가
1a2bf64
murjune added a commit that referenced this pull request Sep 9, 2023
@murjune
#310 [ui] RepresentRuleList Component
b65be9b
murjune added a commit that referenced this pull request Sep 9, 2023
@murjune
#310 [fix] HousCheckBox - Modifier
b888199
murjune added a commit that referenced this pull request Sep 9, 2023
@murjune
#310 [fix] RepresentRuleList - Modifier 변경
e841074
murjune added a commit that referenced this pull request Sep 9, 2023
@murjune
#310 [add] strings
cc369bb
murjune added a commit that referenced this pull request Sep 9, 2023
@murjune
#310 [ui] RuleNavGraph, 대표룰 Screen
58c49cc
murjune added a commit that referenced this pull request Sep 9, 2023
@murjune
#310 [fix] padding 변경
b84b3ca
murjune added a commit that referenced this pull request Sep 9, 2023
@murjune
Merge branch 'develop' into feature/#310-representation-rule-ui-prese…
eeeb491 
…ntation
murjune added a commit that referenced this pull request Sep 9, 2023
@murjune
#310 [ui] navigate Represent Rule Screen
a57c596
murjune added a commit that referenced this pull request Sep 9, 2023
@murjune
#310 [Delete] DeleteRuleScreen
01152cc
murjune added a commit that referenced this pull request Sep 9, 2023
@murjune
#310 [add] 대표 룰 UIModel
0144b73
murjune added a commit that referenced this pull request Sep 9, 2023
@murjune
#310 [chore] lint 추가
56bfc7d
murjune added a commit that referenced this pull request Sep 9, 2023
@murjune
#310 [ui] RepresentRuleList Component
0ed922f
murjune added a commit that referenced this pull request Sep 9, 2023
@murjune
#310 [fix] HousCheckBox - Modifier
a63fe75
murjune added a commit that referenced this pull request Sep 9, 2023
@murjune
#310 [fix] RepresentRuleList - Modifier 변경
33e5ed1
murjune added a commit that referenced this pull request Sep 9, 2023
@murjune
#310 [add] strings
bb43d9d
murjune added a commit that referenced this pull request Sep 9, 2023
@murjune
#310 [ui] RuleNavGraph, 대표룰 Screen
031a36c
murjune added a commit that referenced this pull request Sep 9, 2023
@murjune
#310 [fix] padding 변경
3d93c1c
murjune added a commit that referenced this pull request Sep 9, 2023
@murjune
Merge branch 'ddddddd' into feature/#310-representation-rule-ui-prese…
9b82d8e 
…ntation
murjune added a commit that referenced this pull request Sep 9, 2023
@murjune
#310 [chore] ktlint
59d3f70
murjune added a commit that referenced this pull request Sep 9, 2023
@murjune
Merge pull request #309 from Hous-Release/feature/#310-representation…
825e6d3 
…-rule-ui-presentation

#306 [feat] 대표 룰 UI
@murjune
Copy link
Member Author

murjune commented Sep 9, 2023

Preview1,2,3,4 이렇게 네이밍해도 괜찮은 건가요?? (컴알못...)

@Preview (name = "여기에 설명을 해둠") 이런식으로 설명을 해둬서 딱히 상관없다는 생각을 했는데, 보기 불편한가요?? ㅋㅋㅋㅋ

@murjune murjune closed this Sep 9, 2023
@murjune murjune reopened this Sep 9, 2023
@murjune murjune merged commit 181bbc6 into develop Sep 9, 2023
2 checks passed
@murjune murjune deleted the feature/#308-represent-rule-api-presentation branch September 9, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2zerozu 2zerozu 2zerozu approved these changes

@KWY0218 KWY0218 KWY0218 approved these changes

Assignees

@murjune murjune

Labels
feat 새로운 기능 추가 Pull Request🔥 풀리퀘 날림! 준원🐻 준원이가 작업함!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] 대표 룰 수정 api 및 presentation 로직
3 participants
@murjune @KWY0218 @2zerozu