#305 [Refactor] 기존 domain에 있는 Rule -> BaseRule, MainRule -> Rule 로 네이밍 변경 #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murjune
added
준원🐻
murjune
changed the title
2zerozu
deleted the
feature/#305-fetch-representation-rule-api-usecase
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업한 내용
Rulemodel을BaseRule로 네이밍 수정하였습니다MainRule네이밍이 붙은 부분 모두Rule로 수정PR 포인트
BaseRule로 네이밍하는 것이 적절하다 생각이 들었습니다.대표Rule을 get하는 api와 MainRule을 get하는 api가 거의 일치하기 때문에 app에서 그냥 GetMainRuleUsecase를 사용할 계획입니다.
그런데, 대표룰 ViewModel에서
GetMainRuleUsecase을 불러와 사용한다는 것이 조금 꺼름직해서 기존의 GetMainRuleUsecase를 GetRuleUsecase로 네이밍을 변경하였습니다!