Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web3 1146 wallet connection plus additional utils #8

Merged
merged 17 commits into from
Oct 29, 2024
Merged

Web3 1146 wallet connection plus additional utils #8

merged 17 commits into from
Oct 29, 2024

Conversation

rushby
Copy link
Collaborator

@rushby rushby commented Oct 28, 2024

No description provided.

rushby added 4 commits October 24, 2024 17:31
@rushby
Pass in source wallet and account for withWallet, no longer just pick…
1dd20ba 
…s first account. linting and formatting.
@rushby
Add create extrinsic, extrinsic hex, hex to submittableExtrinsic. Ver…
1260997 
…ify now accepts unformatted proofs OR a pre-built submittable extrinsic. Add format proof api. Update and add new tests
@rushby
Update readme
ff5cca0
@rushby
Refactoring, format, estimateCost, test coverage
121e507
yurikoinaba
yurikoinaba reviewed Oct 28, 2024
View reviewed changes
Copy link
Contributor

@yurikoinaba yurikoinaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be done separately, but please add linting rules to be enforced for the project so that there are minimal diffs in PRs for formatting

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/api/estimate/index.ts Show resolved Hide resolved
src/api/extrinsic/index.ts Outdated Show resolved Hide resolved
src/api/extrinsic/index.ts Outdated Show resolved Hide resolved
src/api/start/index.ts Outdated Show resolved Hide resolved
@rushby
Copy link
Collaborator Author

rushby commented Oct 28, 2024

This can be done separately, but please add linting rules to be enforced for the project so that there are minimal diffs in PRs for formatting

added husky for pre commit and pre push checks

yurikoinaba
yurikoinaba reviewed Oct 29, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/api/format/index.test.ts Show resolved Hide resolved
tests/errors.test.ts Outdated Show resolved Hide resolved
tests/errors.test.ts Outdated Show resolved Hide resolved
@rushby rushby merged commit ee6841c into main Oct 29, 2024
@rushby rushby deleted the WEB3-1146-wallet-connection-plus-additional-utils branch October 29, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davehorizen davehorizen davehorizen approved these changes

@yurikoinaba yurikoinaba yurikoinaba approved these changes

@jmontesdeocanuez jmontesdeocanuez Awaiting requested review from jmontesdeocanuez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rushby @yurikoinaba @davehorizen