Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web3 1188 remove prepare script for package publish #13

Merged
merged 7 commits into from
Nov 1, 2024
Merged

Web3 1188 remove prepare script for package publish #13

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
616e2d0
Ignore scripts for publish package e.g. the prepare script that uses …
rushby Oct 29, 2024
e84e503
Try another method to disable husky for npm publish
rushby Oct 29, 2024
c4e08a7
Try remove the prepare step as part of workflow
rushby Oct 29, 2024
3d5ab57
Another attempt at fixing the prepare script during npm publish
rushby Oct 29, 2024
b03c0a7
Move the retrieval of package version from build to publish job
rushby Oct 29, 2024
b84375b
Single job for build and publish
rushby Nov 1, 2024
5942fd3
Remove unused id
rushby Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 3 additions & 29 deletions .github/workflows/ci-publish-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
workflow_dispatch:

jobs:
build-package:
build-and-publish:
runs-on: ubuntu-latest
env:
SEED_PHRASE_1: ${{ secrets.SEED_PHRASE_1 }}
Expand Down Expand Up @@ -36,39 +36,13 @@ jobs:
run: npm run build

- name: Run tests
id: run_tests
rushby marked this conversation as resolved.
Show resolved Hide resolved
run: npm run test

- name: Extract Package Version
id: extract_version
run: echo "package_version=$(node -p "require('./package.json').version")" >> $GITHUB_ENV

- name: Upload build artifacts
id: upload_build
uses: actions/upload-artifact@v4
with:
name: build
path: ./dist

publish-package:
runs-on: ubuntu-latest
needs: build-package

steps:
- name: Checkout code
uses: actions/checkout@v3

- name: Download build artifacts
uses: actions/download-artifact@v4
with:
name: build
path: ./dist
pattern: '**/*'

- name: Setup Node.js
uses: actions/setup-node@v3
with:
node-version: '18.x'

- name: Authenticate to npm registry
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
Expand All @@ -79,7 +53,7 @@ jobs:
run: npm publish

- name: Send Slack Notification for Publish
if: steps.publish.outcome == 'success'
if: ${{ steps.publish.outcome == 'success' }}
uses: slackapi/[email protected]
with:
payload: |
Expand Down