Multi version and no-std
#4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add cases for 1.2.0-1.1.3 matrix cell. Simplified how to select risc0 version (toml and docs)
DanieleDiBenedetto
approved these changes
Dec 11, 2024
…e hash implementation. - Add last matrix test cases - little docs fix up
lgiussan
reviewed
Dec 16, 2024
la10736
commented
Dec 19, 2024
There was a problem hiding this comment.
For the sake of uniformity, we could treat also the latest version in the same manner as the previous ones (i.e. copy-pasting the circuits inside of
src/circuit/v1_2, instead of importing therisc0_circuit_rv32imandrisc0_circuit_recursioncrates)?
I was fought about what's the best approach here. Anyway maybe the actula one is little bit fragile because we need to use = in cargo toml to avoid unexpected updataing. So, I'll accept your subbestion
…local source. - Some refactor - removed unused files
- Add the method used to create the tests - Add test for segment context stability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support multiple risc0 version in
no-stdMost of the code come from
risc0-zkvmcrate: just removed useless implementations.In
generate_proofsthere is a program to generate method and proofs. Theheader-fixfolder conatins a simple script to mix license headers from risc0 and our..Add a test for no-std.