-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crates io stable2407 #1
base: master
Are you sure you want to change the base?
Conversation
# Branch notes | ||
|
||
Based on the branch 'stable2407' from https://github.com/polkadot-evm/frontier/ where we first replaced all reference to the polkadot | ||
git branch in `Cargo.toml` with a fake version `9.9.9` and the use `update-polkadot-sdk-deps.py` script from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: the use -> then used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also: all reference -> all references
# Branch notes | ||
|
||
Based on the branch 'stable2407' from https://github.com/polkadot-evm/frontier/ where we first replaced all reference to the polkadot | ||
git branch in `Cargo.toml` with a fake version `9.9.9` and the use `update-polkadot-sdk-deps.py` script from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also: all reference -> all references
## ATTENTION | ||
|
||
`substrate-test-runtime-client` is not published, so leave the definition pointing to a git source. | ||
Why this is wrong: because the `substrate-test-runtime-client` use lot of substrate dependency |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo:
use lot of substrate dependency -> uses lot of substrate dependencies
No description provided.