teensy_loader_cli 2.1 (devel)

[oskargargas]

Update to allow use of devel repository instead of outdated (2013-ish) zip source distribution and expose libusb compilation flags.

[oskargargas]

It is similar update to https://github.com/Homebrew/homebrew/pull/45558/files?diff=unified but after providing patches to upstream which were accepted.

I'm not sure if providing --with-xxx option which is available only for --devel or --HEAD builds is a proper way. Couldn't find anything in the docs about providing --with-xxx for devel only. If it should be done in some different way please advise.

Upstream unfortunately doesn't version this app so I wasn't sure if updating base installation to newest commit is a good choice and left the original zip source distribution as standard way of install... thou it is hell outdated and doesn't support many of development boards supported by newest git version.

[oskargargas]

I just saw that tests failed for --develop. How should I approach testing when stable and develop don't have a common output?

[dunn]

If it's not possible to write a test that passes both, you can use build.stable? and build.devel?

[oskargargas]

Thanks for the answer. I can't find any documentation on how to do it. If I place if build.devel/stable? then inside test block it looks like it never goes into the statement. Could you direct me to some example of such case?

[dunn]

Actually, I may be wrong. We allow build.with? in test blocks, but I'm not sure if the test block has access to build.stable? and build.devel?. We may fix that (feel free to submit a PR!) but in the meantime I'm afraid you'll need a compatible test.

[DomT4]

Can cut this option.

[oskargargas]

Done

[oskargargas]

Fixed all checks and review comments. Please merge or advise what to do next.

[MikeMcQuaid]

Can you explain why SDK doesn't need to be set when using libusb? Thanks!

[oskargargas]

teensy_loader_cli codebase is a bit outdated. There is a lot #ifdefs inside. Pure OSX codebase is not fully implemented. Using libusb allows use of Linux codepath which is fully implemented, especially allows for use of soft reboots of connected board.

[MikeMcQuaid]

@oskargargas I merged this by mistake and have removed the devel in d8838fa as it's not a tagged version. If there's a tag for that: please open a new pull request for it.

Thanks for your contribution to Homebrew, though! Without people like you submitting PRs we couldn't run this project. You rock!

[oskargargas]

@MikeMcQuaid it's not probable that upstream will tag versions anytime soon. I understand why you removed the devel. Current HEAD will do as long as something doesn't change. Is there any way to let's say self tag something for Homebrew?

FYI #45558 is a duplicate and after this merge could be closed as well.

[MikeMcQuaid]

FYI #45558 is a duplicate and after this merge could be closed as well.

Thanks, closed.

Is there any way to let's say self tag something for Homebrew?

Unfortunately not; we only use upstream versions.