Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected], [email protected]: don't set GOTOOLCHAIN=local #204435

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

stefanb
Copy link
Member

@stefanb stefanb commented Jan 16, 2025

Pending decision in

Fixes #202030
Follow-up to #204351

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue legacy Relates to a versioned @ formula labels Jan 16, 2025
@stefanb stefanb mentioned this pull request Jan 16, 2025
4 tasks
@stefanb stefanb force-pushed the gotoolchain-local-legacy branch from b2e8644 to 7f72389 Compare January 16, 2025 06:38
@stefanb stefanb force-pushed the gotoolchain-local-legacy branch from 7f72389 to bd79c1c Compare January 16, 2025 22:00
@stefanb stefanb marked this pull request as ready for review January 16, 2025 22:01
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jan 16, 2025
@BrewTestBot BrewTestBot enabled auto-merge January 16, 2025 22:38
@BrewTestBot BrewTestBot added this pull request to the merge queue Jan 16, 2025
Merged via the queue into master with commit 88f4f90 Jan 16, 2025
15 checks passed
@BrewTestBot BrewTestBot deleted the gotoolchain-local-legacy branch January 16, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue legacy Relates to a versioned @ formula
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go: don't set GOTOOLCHAIN=local
3 participants