Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruby 3.4.1 ruby 3.3.6 (new formula) #202443

Merged
merged 55 commits into from
Dec 26, 2024
Merged

ruby 3.4.1 ruby 3.3.6 (new formula) #202443

merged 55 commits into from
Dec 26, 2024

Conversation

p-linnane
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Dec 25, 2024
@chenrui333 chenrui333 added the long build Set a long timeout for formula testing label Dec 25, 2024
@chenrui333 chenrui333 changed the title ruby 3.4.1 ruby 3.4.1 ruby 3.3.6 (new formula) Dec 25, 2024
@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Dec 25, 2024
@chenrui333 chenrui333 added audit failure CI fails while auditing the software CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Dec 26, 2024
@chenrui333 chenrui333 removed the audit failure CI fails while auditing the software label Dec 26, 2024
@ZhongRuoyu ZhongRuoyu added the CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. label Dec 26, 2024
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Dec 26, 2024
@p-linnane
Copy link
Member Author

Thanks for all the hard work here @chenrui333!

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest moving gel deprecation to a separate PR so we can merge with 🟢 CI

@chenrui333
Copy link
Member

chenrui333 commented Dec 26, 2024

Suggest moving gel deprecation to a separate PR so we can merge with 🟢 CI

gel test actually failed for linux build due to the time out issue (I was thinking the deprecation would ignore the formula), let me move it to a separate pr

just moved the gel deprecation into a separate pr

@chenrui333 chenrui333 mentioned this pull request Dec 26, 2024
6 tasks
p-linnane and others added 3 commits December 26, 2024 10:03
Formula/c/cucumber-cpp.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Dec 26, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Dec 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 26, 2024
@p-linnane
Copy link
Member Author

The sonoma bottle for ruby has a hash mismatch. Investigating.

@carlocab carlocab added this pull request to the merge queue Dec 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 26, 2024
Formula/r/ruby.rb Outdated Show resolved Hide resolved
@chenrui333
Copy link
Member

yeah, I think we can followup with a rebottle

Co-authored-by: Carlo Cabrera <[email protected]>
@chenrui333 chenrui333 enabled auto-merge December 26, 2024 19:25
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the right code suggestion was applied: #202443 (comment)

But let's see.

@chenrui333 chenrui333 added this pull request to the merge queue Dec 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to Branch Protection failures Dec 26, 2024
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@carlocab carlocab added this pull request to the merge queue Dec 26, 2024
Merged via the queue into master with commit b159caa Dec 26, 2024
19 checks passed
@carlocab carlocab deleted the bump-ruby-3.4.1 branch December 26, 2024 19:38
@carlocab
Copy link
Member

Rebottled at https://github.com/Homebrew/homebrew-core/actions/runs/12507715499

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. long build Set a long timeout for formula testing new formula PR adds a new formula to Homebrew/homebrew-core ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants