php: Remove unknown configure flags and add SNMP #199193
Open
+5
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
icu4c
chenrui333
added
the
automerge-skip
SMillerDev
reviewed
Nov 27, 2024
github-actions
bot
added
autosquash
The pspell extension has been removed in 8.4. See https://www.php.net/manual/en/migration84.removed-extensions.php This removes the dependency on aspell and the configure flag `--with-pspell`. The configure flag `--with-kerberos` is also unrecognized (warning in configure output). Add the SNMP extension back and add test. It was only broken back when we had mixed crypto linking in old macOS.
github-actions
bot
removed
the
autosquash
Sure. It'll be mostly dummy code like the LDAP test because a real test would require a network SNMP server. It won't crash the process at least. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pspell extension has been removed in 8.4. See https://www.php.net/manual/en/migration84.removed-extensions.php This removes the dependency on aspell and the configure flag
--with-pspell.The configure flag
--with-kerberosis also unrecognized (warning in configure output).Add the SNMP extension back. It was only broken back when we had mixed crypto linking in old macOS.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?