Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet 9.0.0 #196479

Merged
merged 4 commits into from
Nov 16, 2024
Merged

dotnet 9.0.0 #196479

merged 4 commits into from
Nov 16, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Nov 3, 2024

Going to start pre-release testing .NET 9 to check on state of various workarounds/patches.

TODO:

@cho-m cho-m added pre-release Artifact is pre-release prerelease-testing Pull request from upstream, testing a pre-release with homebrew dependencies labels Nov 3, 2024
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request CI-linux-self-hosted Build on Linux self-hosted runner long build Set a long timeout for formula testing labels Nov 3, 2024
@cho-m cho-m added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Nov 3, 2024
@cho-m cho-m force-pushed the bump-dotnet-9.0.0 branch 3 times, most recently from 66c086e to 3f9ed01 Compare November 3, 2024 02:43
Base automatically changed from bump-dotnet-8.0.10 to master November 3, 2024 10:51
@cho-m cho-m force-pushed the bump-dotnet-9.0.0 branch 3 times, most recently from 86c2d00 to 6ff4ee7 Compare November 3, 2024 16:52
@cho-m
Copy link
Member Author

cho-m commented Nov 3, 2024

Noting down current status:

  • macOS seems okay now at 6ff4ee7. There are annoying sporadic failures which have already been reported upstream by others. May be fixed when newer bootstrap is available.

  • Linux is building now, but test is showing some extra characters.

      ==> /home/linuxbrew/.linuxbrew/Cellar/dotnet/9.0.0/bin/dotnet run --framework net9.0 /tmp/dotnet-test-20241103-142887-5xaely/test.dll a b c
      Error: dotnet: failed
      An exception occurred within a child process:
        Minitest::Assertion: --- expected
      +++ actual
      @@ -1,2 +1,2 @@
      -"/tmp/dotnet-test-20241103-142887-5xaely/test.dll,a,b,c
      +"\e]9;4;3;\e\\\e]9;4;0;\e\\/tmp/dotnet-test-20241103-142887-5xaely/test.dll,a,b,c
       "
    

May try switching back to Clang build on Linux which is probably better supported.

@cho-m cho-m force-pushed the bump-dotnet-9.0.0 branch 16 times, most recently from dbc7b50 to fdeae20 Compare November 9, 2024 14:04
@chenrui333 chenrui333 mentioned this pull request Nov 15, 2024
@cho-m cho-m force-pushed the bump-dotnet-9.0.0 branch from 58d7f3f to e66998b Compare November 16, 2024 14:16
@cho-m cho-m added CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. and removed blocked automerge-skip `brew pr-automerge` will skip this pull request labels Nov 16, 2024
@cho-m cho-m force-pushed the bump-dotnet-9.0.0 branch from e66998b to 2e51c8f Compare November 16, 2024 17:57
@cho-m cho-m removed the CI-linux-self-hosted Build on Linux self-hosted runner label Nov 16, 2024
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request CI-linux-self-hosted Build on Linux self-hosted runner labels Nov 16, 2024
@cho-m cho-m removed CI-linux-self-hosted Build on Linux self-hosted runner automerge-skip `brew pr-automerge` will skip this pull request labels Nov 16, 2024
@cho-m cho-m marked this pull request as ready for review November 16, 2024 18:07
@cho-m
Copy link
Member Author

cho-m commented Nov 16, 2024

.NET 8 successfully built on non-self-hosted Linux after switching to tarball. Trying out if possible with .NET 9.

@cho-m cho-m added the ready to merge PR can be merged once CI is green label Nov 16, 2024
@cho-m
Copy link
Member Author

cho-m commented Nov 16, 2024

Ready to merge as 14-x86_64 is an existing issue with a broken bottle. May need to be try on Intel Sequoia to see if it is happening on all Intel macOS running Xcode 16. Sadly haven't been able to build on Rosetta so can't check on that. At least can confirm the Sonoma bottle is broken testing on Sequoia (Rosetta).

Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Nov 16, 2024
@github-actions github-actions bot added the CI-linux-self-hosted Build on Linux self-hosted runner label Nov 16, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 16, 2024
Merged via the queue into master with commit 507ed53 Nov 16, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the bump-dotnet-9.0.0 branch November 16, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-linux-self-hosted Build on Linux self-hosted runner CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. long build Set a long timeout for formula testing ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants