Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubefirst 2.3.5 #153052

Merged
merged 2 commits into from
Nov 7, 2023
Merged

kubefirst 2.3.5 #153052

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cc5082
kubefirst 2.3.5
claywd Nov 2, 2023
384806b
kubefirst: update 2.3.5 bottle.
BrewTestBot Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions Formula/k/kubefirst.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
class Kubefirst < Formula
desc "GitOps Infrastructure & Application Delivery Platform for kubernetes"
homepage "https://kubefirst.io/"
url "https://github.com/kubefirst/kubefirst/archive/refs/tags/v2.2.17.tar.gz"
sha256 "cb0d4e265b7bc2c75c2a5898dde3af126a2bc159b203cd61901611149f8d7433"
url "https://github.com/kubefirst/kubefirst/archive/refs/tags/v2.3.5.tar.gz"
sha256 "b6529903b8af149805dd5ec5c41310a103522d3a7398430f00746218c9a9603e"
license "MIT"
head "https://github.com/kubefirst/kubefirst.git", branch: "main"

Expand All @@ -14,31 +14,33 @@ class Kubefirst < Formula
end

bottle do
sha256 cellar: :any_skip_relocation, arm64_sonoma: "5fba5fc8f5756219d212160b27f6ffdb941b9d53ca1bc57f6dc9da4a09000ee6"
sha256 cellar: :any_skip_relocation, arm64_ventura: "563b61c9e5ee02b9e4f85a75bd58e74a1aa1fdfae7ad9b075000d12af08cc5dc"
sha256 cellar: :any_skip_relocation, arm64_monterey: "2d5cb90d83642b1576e6a3f4bf7301c839a3371766f6c91965fe11c2db37b36d"
sha256 cellar: :any_skip_relocation, arm64_big_sur: "50b02b8c5364a5c41821600ced58be5ddc009ab00ed61174bc29e883321fed1a"
sha256 cellar: :any_skip_relocation, sonoma: "2ad1a9600488ca02a442593d0e9ec4becc7ade67bbf75d2669e17e6d8d1fcb8d"
sha256 cellar: :any_skip_relocation, ventura: "4de2288766dc8c673cae5a3086e2676b57ecd954b10eb94bf658c55454322b88"
sha256 cellar: :any_skip_relocation, monterey: "42e28bf6b75e2149749bfdf30f178528688f37d756889ec87942b36df46ae135"
sha256 cellar: :any_skip_relocation, big_sur: "9d73fe8aaf8ff391a60e51a3fb3a48abcf1a7a9ad0fc12ce3a3ca91e4bf0c236"
sha256 cellar: :any_skip_relocation, x86_64_linux: "78b87bd5290d252af468fe4ca52b766c221950ccb4b196bfd117c029aae3acc4"
sha256 cellar: :any_skip_relocation, arm64_sonoma: "d596b7fc05dff0cd159b7d6a0f00b87230b1a0286de3e4b48ddad19913b28009"
sha256 cellar: :any_skip_relocation, arm64_ventura: "a3d9e300543495d497831230bf3227f1de7b185948d1263e7f96bc6d9a512d45"
sha256 cellar: :any_skip_relocation, arm64_monterey: "8906967de3a5675498446a09871777c208a24b4ecd86557de8443484cf12c61e"
sha256 cellar: :any_skip_relocation, sonoma: "1d418a7ed1a9f421531df5d60af7bb1dbceaf5aca16d71f658dfba4371f1774d"
sha256 cellar: :any_skip_relocation, ventura: "1f37ccfa16d039cd17335b12e88653adc16670e1572e1379d9400535005e3330"
sha256 cellar: :any_skip_relocation, monterey: "dbf4336901b2dc03e66f2161558b81112d5c35ba8f955231e1a693a565e1cecd"
sha256 cellar: :any_skip_relocation, x86_64_linux: "77a3c5a09438177c95d37d656c30b9a5b03e3cba772785a3928d93df1a3b18b2"
end

depends_on "go" => :build

def install
ldflags = "-s -w -X github.com/kubefirst/runtime/configs.K1Version=v#{version}"
system "go", "build", *std_go_args(ldflags: ldflags)

generate_completions_from_executable(bin/"kubefirst", "completion")
end
Comment on lines 30 to 31
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So just to confirm: shell completions which is being removed here is intentional and will no longer be supported?

Copy link
Member

@alebcay alebcay Nov 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm this @k8swrangler, due to the hanging issue we cannot ship completions out of the box. Users will have to run kubefirst completion > some_file.sh and Ctrl + C on their own after installing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify: kubefirst completion doesn't generate the files. The user would need to pipe that to the appropriate locations and hit Ctrl+C.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, edited my comment to make that clear.

Copy link
Contributor Author

@claywd claywd Nov 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shell command completion is one of those things that is almost never used in our app so it's not a priority. This cli is more an initial interface to the actual app which has grown beyond the cli


test do
system bin/"kubefirst", "info"
assert_match "k1-paths:", (testpath/".kubefirst").read
assert_predicate testpath/".k1/logs", :exist?

assert_match "v#{version}", shell_output("#{bin}/kubefirst version")
output = shell_output("#{bin}/kubefirst version")
expected = if OS.linux? && ENV["HOMEBREW_GITHUB_ACTIONS"]
""
else
version.to_s
end
assert_match expected, output
end
end
Loading