Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: add triage-ci.yml #131950

Merged
merged 1 commit into from
May 25, 2023
Merged

Conversation

carlocab
Copy link
Member

This will allow us to add automation that will be done after CI
failures.

For now, we can automate pinging @woodruffw and @alex on failures of
the brew-pip-audit workflow to avoid other maintainers from having to
manually do this.

See related discussions at #131661.

This will allow us to add automation that will be done after CI
failures.

For now, we can automate pinging `@woodruffw` and `@alex` on failures of
the `brew-pip-audit` workflow to avoid other maintainers from having to
manually do this.

See related discussions at Homebrew#131661.
@carlocab carlocab requested review from a team and MikeMcQuaid as code owners May 25, 2023 08:36
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request workflows PR modifies GitHub Actions workflow files labels May 25, 2023
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, we can automate pinging @woodruffw and @alex on failures of
the brew-pip-audit workflow to avoid other maintainers from having to
manually do this.

Could this be done in that workflow instead?

@alex
Copy link
Contributor

alex commented May 25, 2023

I think that's phrased in a confusing way: brew-pip-audit generates regular PRs to bump resources in formulas, we're interested in CI failures on those PRs, not failures in brew-pip-audit itself.

@carlocab
Copy link
Member Author

I think that's phrased in a confusing way: brew-pip-audit generates regular PRs to bump resources in formulas, we're interested in CI failures on those PRs, not failures in brew-pip-audit itself.

Yes, exactly, sorry for the lack of clarity.

Given the desired behaviour the workflow needs to live here. I can stick this into an existing workflow (e.g. automerge.yml), but I imagine we'd rather have shorter workflows that do specific things rather than fewer but longer workflows that do multiple different things.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks: with that context this approach makes sense to me!

Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @carlocab!

@carlocab carlocab added this pull request to the merge queue May 25, 2023
Merged via the queue into Homebrew:master with commit 7d23faa May 25, 2023
@carlocab carlocab deleted the triage-ci-failures branch May 25, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request workflows PR modifies GitHub Actions workflow files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants