Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duckscript: use system TLS instead of rustls #113077

Closed
wants to merge 1 commit into from
Closed

duckscript: use system TLS instead of rustls #113077

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions Formula/duckscript.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,11 @@ class Duckscript < Formula

on_linux do
depends_on "pkg-config" => :build
depends_on "openssl@1.1" # Uses Secure Transport on macOS
depends_on "openssl@3" # Uses Secure Transport on macOS
end

def install
cd "duckscript_cli" do
system "cargo", "install", *std_cargo_args
end
system "cargo", "install", "--features", "tls-native", *std_cargo_args(path: "duckscript_cli")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to make sure of linkage. Open to opinions on whether we should favor the statically linked pure Rust implementation vs dynamically linked system/Homebrew library.

Upstream changed from native OpenSSL to rustls, and then added option afterward https://github.com/sagiegurari/duckscript/blob/master/CHANGELOG.md#v0813-2022-07-21

### v0.8.13 (2022-07-21)

* Enhancement: Runtime - Enable to clone duckscript context #253 (thanks waterlens)
* Enhancement: Support both native TLS via openssl and pure rust TLS #258 (thanks @jirutka)

### v0.8.12 (2022-05-25)

* Enhancement: Add support for stdin input passing to child process in exec, watchdog and spawn commands #247
* Enhancement: Replace native TLS support via openssl with pure rust TLS
* Update dependencies

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old linkage #112420:

==> brew linkage --cached duckscript
System libraries:
  /lib/x86_64-linux-gnu/libc.so.6
  /lib/x86_64-linux-gnu/libgcc_s.so.1
  /lib/x86_64-linux-gnu/libm.so.6

New linkage:

==> brew linkage --cached duckscript
System libraries:
  /lib/x86_64-linux-gnu/libc.so.6
  /lib/x86_64-linux-gnu/libgcc_s.so.1
  /lib/x86_64-linux-gnu/libm.so.6
Homebrew libraries:
  /home/linuxbrew/.linuxbrew/opt/openssl@3/lib/libcrypto.so.3 (openssl@3)
  /home/linuxbrew/.linuxbrew/opt/openssl@3/lib/libssl.so.3 (openssl@3)

end

test do
Expand Down