Use 8-bit color indices consistently #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, we sometimes used 8-bit indices and sometimes 16-bit ones, because the reverse-engineered format documentation described it that way. However, these does not seem to be a good reason why there should be 16-bit color indices when the value it contains is just 8-bit. It's likely that the most significant byte actually belongs to another field. Also see: Deep-Symmetry/crate-digger#27
Swiftb0y
approved these changes
Apr 7, 2022
There was a problem hiding this comment.
Code looks good to me. Though we should wait with merging until this was discussed "upstream" (Deep-Symmetry/crate-digger#27)
Swiftb0y
approved these changes
Apr 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we sometimes used 8-bit indices and sometimes 16-bit ones,
because the reverse-engineered format documentation described it that
way.
However, these does not seem to be a good reason why there should be
16-bit color indices when the value it contains is just 8-bit. It's
likely that the most significant byte actually belongs to another field.
Also see:
Deep-Symmetry/crate-digger#27