Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Adam Johnson <[email protected]>
  • Loading branch information
colincornaby and Hoikas committed Jul 18, 2024
1 parent 28e387d commit f956772
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion urumanifest/commit.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def _hash_asset(args: Tuple[Path, Path, bool]) -> Tuple[Path, str, int]:
bundle_name = source_path.stem
# Guess the executable path - we could get the exact name if we could unpack the Info.plist
# in a cross platform way.
source_path = source_path.joinpath("Contents", MacOS", bundle_name)
source_path = source_path.joinpath("Contents", MacOS", bundle_name)
with source_path.open("rb") as in_stream:
_io_loop(in_stream, h.update)
return server_path, h.hexdigest(), source_path.stat().st_size
Expand Down
1 change: 1 addition & 0 deletions urumanifest/github.py
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,7 @@ class ArtifactInfo(NamedTuple):
name: str
bundle: bool = False


def _unpack_artifact(staging_path: Path, database: _WorkflowDatabase, rev: str, name: str, artifact: tempfile.NamedTemporaryFile):
logging.debug(f"Decompressing {name}.zip from {artifact.name}")

Expand Down

0 comments on commit f956772

Please sign in to comment.