Skip to content

Commit

Permalink
merging PR Chaosthebot#518: Ignore neutral reviews
Browse files Browse the repository at this point in the history
Chaosthebot#518: Ignore neutral reviews

Description:
Currently a neutral review (the default when you use "add single comment" instead of "start a review") will override an approval. This PR makes chaosbot ignore netural reviews, so they don't override positive reviews. A positive review can still be overriden with a negative review (which currently is treated the same as no review at all).

:white_check_mark: PR passed with a vote of 7 for and 0 against, a weighted total of 7.0 and a threshold of 6.5, and a current meritocracy review.

Vote record:
@PlasmaPower: 1
@Swizz: 1
@andrewda: 1
@JustynC7: 1
@mark-i-m: 1
@phil-r: 1
@rhengles: 1
  • Loading branch information
PlasmaPower authored and chaosbot committed Jun 5, 2017
1 parent 07d79cf commit fb9b397
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion github_api/voting.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,8 @@ def get_pr_review_reactions(api, urn, pr):
user = review["user"]["login"]
is_current = review["commit_id"] == pr["head"]["sha"]
vote = parse_review_for_vote(state)
yield user, is_current, vote
if vote != 0:
yield user, is_current, vote


def get_vote_weight(api, username, contributors):
Expand Down

0 comments on commit fb9b397

Please sign in to comment.